| From: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
|---|---|
| To: | Heikki Linnakangas <hlinnakangas(at)vmware(dot)com> |
| Cc: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Archive recovery won't be completed on some situation. |
| Date: | 2014-05-12 16:23:04 |
| Message-ID: | CAHGQGwFAhGZmBnW3VCCRxp04tJ84fP0roVzFk2aEC13h2Rgxgw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, May 12, 2014 at 8:40 PM, Heikki Linnakangas
<hlinnakangas(at)vmware(dot)com> wrote:
> On 05/12/2014 02:29 PM, Fujii Masao wrote:
>>
>> Hmm.. probably I have the same opinion with you. If I understand this
>> correctly,
>> an immediate shutdown doesn't call CancelBackup() in 9.4 or before. But
>> the
>> commit 82233ce unintentionally changed an immediate shutdown so that it
>> calls
>> CancelBackup().
>
>
> Oh, sorry. I thought it was the other way 'round: that we used to remove
> backup_label on an immediate shutdown on 9.3 and before, but that 9.4
> doesn't do that anymore. Now that I re-read this thread and tested it
> myself, I see that I got it backwards.
>
> I agree the new behavior is better, and we should just remove the Open Items
> entry.
Yes. I just removed that entry.
Regards,
--
Fujii Masao
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2014-05-12 16:25:59 | Re: Proposal for CSN based snapshots |
| Previous Message | Heikki Linnakangas | 2014-05-12 16:14:55 | Re: Proposal for CSN based snapshots |