From: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
---|---|
To: | Etsuro Fujita <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp> |
Cc: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Jeff Janes <jeff(dot)janes(at)gmail(dot)com>, Sawada Masahiko <sawada(dot)mshk(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, Jesper Krogh <jesper(at)krogh(dot)cc>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: PENDING_LIST_CLEANUP_SIZE - maximum size of GIN pending list Re: HEAD seems to generate larger WAL regarding GIN index |
Date: | 2014-11-11 12:11:54 |
Message-ID: | CAHGQGwF1whOmOh8cZhQx+fTzgVY7zUYWS9BaVvXjc346B1=OwQ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Tue, Nov 11, 2014 at 7:01 PM, Etsuro Fujita
<fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp> wrote:
> (2014/11/11 2:31), Fujii Masao wrote:
>>
>> On Mon, Nov 10, 2014 at 4:15 PM, Etsuro Fujita
>>>
>>> The patch looks good to me except for the following point:
>
>
>>> *** a/src/backend/access/gin/ginfast.c
>>> --- b/src/backend/access/gin/ginfast.c
>>> ***************
>>> *** 25,30 ****
>>> --- 25,32 ----
>>> #include "utils/memutils.h"
>>> #include "utils/rel.h"
>>>
>>> + /* GUC parameter */
>>> + int pending_list_cleanup_size = 0;
>>>
>>> I think we need to initialize the GUC to boot_val, 4096 in this case.
>>
>>
>> No, IIUC basically the variable for GUC doesn't need to be initialized
>> to its default value. OTOH, it's also harmless to initialize it to the
>> default.
>> I like the current code a bit because we don't need to change the initial
>> value again when we decide to change the default value of GUC.
>> I have no strong opinion about this, though.
>
>
> OK, so if there are no objections of others, I'll mark this as "Ready for
> Committer".
I just pushed this. Thanks!
Regards,
--
Fujii Masao
From | Date | Subject | |
---|---|---|---|
Next Message | Alvaro Herrera | 2014-11-11 12:12:38 | Re: BRIN indexes - TRAP: BadArgument |
Previous Message | Michael Paquier | 2014-11-11 12:11:02 | Re: pg_prewarm really needs some CHECK_FOR_INTERRUPTS |