Re: pgsql: Don't forget to flush XLOG_PARAMETER_CHANGE record.

On Wed, Mar 26, 2014 at 5:39 AM, Simon Riggs <simon(at)2ndquadrant(dot)com> wrote:
> On 25 March 2014 19:59, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> Robert Haas <robertmhaas(at)gmail(dot)com> writes:
>>> This commit message doesn't give any indication of what the
>>> consequences of this oversight are. I think that's generally a good
>>> thing to include.
>>
>> Yes, please. We (usually Bruce or I) make release notes based on the
>> commit logs. Please be sure your commit message includes enough info
>> to write a useful release note about the change.
>
> I don't think there are any consequences. All it seems to do is slow
> down recovery by an XLogFlush(), which admitedly isn't much

Yes. And basically the XLogFlush that the patch added is executed only
when wal_level is changed. It's not quite so common code path, I think.

Regards,

--
Fujii Masao