| From: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
| Cc: | PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Remove invalid indexes from pg_dump Was: Support for REINDEX CONCURRENTLY |
| Date: | 2013-03-26 17:34:50 |
| Message-ID: | CAHGQGwEeb8yVs5xDnQf_kyVVUSWurY3_mS949=EUgLS2pciTQg@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Mar 19, 2013 at 9:19 AM, Michael Paquier
<michael(dot)paquier(at)gmail(dot)com> wrote:
> If failures happen with CREATE INDEX CONCURRENTLY, the system will be let
> with invalid indexes. I don't think that the user would like to see invalid
> indexes of
> an existing system being recreated as valid after a restore.
> So why not removing from a dump invalid indexes with something like the
> patch
> attached?
+1
The patch looks good to me.
> This should perhaps be applied in pg_dump for versions down to 8.2 where
> CREATE
> INDEX CONCURRENTLY has been implemented?
I think so.
Regards,
--
Fujii Masao
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kevin Grittner | 2013-03-26 17:50:27 | Re: Limiting setting of hint bits by read-only queries; vacuum_delay |
| Previous Message | Heikki Linnakangas | 2013-03-26 17:26:26 | Re: [COMMITTERS] pgsql: Add PF_PRINTF_ATTRIBUTE to on_exit_msg_fmt. |