| From: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
|---|---|
| To: | Joshua Berkus <josh(at)agliodbs(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, Peter Eisentraut <peter_e(at)gmx(dot)net>, Simon Riggs <simon(at)2ndquadrant(dot)com>, Magnus Hagander <magnus(at)hagander(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: unite recovery.conf and postgresql.conf |
| Date: | 2011-09-27 08:33:31 |
| Message-ID: | CAHGQGwEPL8u=e0-evf7+FiQnRMwAXg46cHKvOP9YPq4SOT61iA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Sep 20, 2011 at 3:38 PM, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
>>> What about "recovery.trigger"?
>
> I'm OK with that name.
<snip>
>>> * is there any security hazard from ordinary users being able to see
>>> what settings had been used?
>>
>> primary_conninfo could be a problem, since it's possible to set a password there.
>
> True. I agree that primary_conninfo should be restricted to superuser.
Though there is still ongonig discussion, since there is no objection about
the above two changes, I revised the patch that way. And I fixed the minor
bug handling the default value of recovery_target_timeline wrongly.
Attached is the revised version of the patch.
Regards,
--
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center
| Attachment | Content-Type | Size |
|---|---|---|
| unite_recoveryconf_postgresqlconf_v2.patch | text/x-patch | 112.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | andurkar | 2011-09-27 08:44:48 | Postgresql parser |
| Previous Message | Kohei KaiGai | 2011-09-27 08:13:17 | Re: contrib/sepgsql regression tests are a no-go |