Re: Add generate_series(numeric, numeric)

From: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
To: Ali Akbar <the(dot)apaan(at)gmail(dot)com>
Cc: Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Marti Raudsepp <marti(at)juffo(dot)org>, Платон Малюгин <malugin(dot)p(at)gmail(dot)com>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Add generate_series(numeric, numeric)
Date: 2015-02-26 06:49:06
Message-ID: CAHGQGwE1mdWjZWUXmrWoXjTAnS3+NkD2r44sOt8kCJqbx5BcnA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Jan 14, 2015 at 11:04 AM, Ali Akbar <the(dot)apaan(at)gmail(dot)com> wrote:
>
> 2014-12-18 19:35 GMT+07:00 Fujii Masao <masao(dot)fujii(at)gmail(dot)com>:
>>
>> On Mon, Dec 15, 2014 at 2:38 PM, Andrew Gierth
>> <andrew(at)tao11(dot)riddles(dot)org(dot)uk> wrote:
>> > I was thinking something like this, added just after that para:
>> >
>> > <warning>
>> > <para>
>> > While the actual arguments to the function remain unchanged
>> > between
>> > calls, if you detoast the argument values (which is normally done
>> > transparently by the
>> > <function>PG_GETARG_<replaceable>xxx</replaceable></function>
>> > macro)
>> > in the transient context then the detoasted copies will be freed
>> > on
>> > each cycle. Accordingly, if you keep references to such values in
>> > your <structfield>user_fctx</>, you must either copy them into the
>> > <structfield>multi_call_memory_ctx</> after detoasting, or ensure
>> > that you detoast the values only in that context.
>> > </para>
>> > </warning>
>>
>> I'm OK with this.
>
>
> Wrapping the doc changes in a patch. Will add to next commitfest so it won't
> be lost.

Pushed. Thanks!

Regards,

--
Fujii Masao

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message James Sewell 2015-02-26 07:34:34 Composite index and min()
Previous Message Sergey Shchukin 2015-02-26 06:25:31 Re: [pgadmin-support] Issue with a hanging apply process on the replica db after vacuum works on primary