| From: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
| Cc: | PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Inconsistent use of --slot/-S in pg_receivexlog and pg_recvlogical |
| Date: | 2014-08-13 02:04:38 |
| Message-ID: | CAHGQGwE+rNQNzMBcMNdor4xY6USpAUhVL-90D+LQAYP6GdAZmQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Aug 12, 2014 at 7:27 PM, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
> On Tue, Aug 12, 2014 at 4:50 PM, Michael Paquier
> <michael(dot)paquier(at)gmail(dot)com> wrote:
>> Hi,
>>
>> I noticed that pg_receivexlog is able to use --slot but not -S, even
>> if the code is written this way. Attached is a patch correcting that.
>> This makes pg_receivexlog consistent with pg_recvlogical regarding the
>> slot option.
>> IMHO, this should be backpatched to REL9_4_STABLE.
>> Regards,
>
> Looks good to me. And, I could not find the reason why only -S was not
> added, in the past discussion.
>
> Anyway, barring any objection, I will commit this.
Applied. Thanks!
Regards,
--
Fujii Masao
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Noah Misch | 2014-08-13 03:19:18 | Re: strncpy is not a safe version of strcpy |
| Previous Message | Heikki Linnakangas | 2014-08-12 23:36:59 | Re: WAL format and API changes (9.5) |