| From: | Euler Taveira <euler(at)timbira(dot)com(dot)br> |
|---|---|
| To: | Dave Cramer <davecramer(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Comment refers to non existent function IncreaseRestartDecodingForSlot |
| Date: | 2018-06-29 20:34:21 |
| Message-ID: | CAHE3wgjYT1itez6hm3wuWAtVexnYeOR0V1YnH0Qo+bqH9wKjTQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
2018-06-29 15:55 GMT-03:00 Dave Cramer <davecramer(at)gmail(dot)com>:
> While trying to figure out this code I found
>
> https://git.postgresql.org/gitweb/?p=postgresql.git;a=blob;f=src/backend/replication/logical/logical.c;h=61588d626f608006196c769ad9807f1d3ac592e9;hb=HEAD#l913
>
> What function should it be referring to ?
>
LogicalIncreaseXminForSlot (it is a few lines above). It has been like
that since logical decoding was introduced. The trivial patch fixes
it.
--
Euler Taveira Timbira -
http://www.timbira.com.br/
PostgreSQL: Consultoria, Desenvolvimento, Suporte 24x7 e Treinamento
| Attachment | Content-Type | Size |
|---|---|---|
| typo.patch | text/x-patch | 666 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2018-06-29 20:42:36 | Re: SCRAM with channel binding downgrade attack |
| Previous Message | Dave Cramer | 2018-06-29 18:55:02 | Comment refers to non existent function IncreaseRestartDecodingForSlot |