From: | Chethana Kumar <chethana(dot)kumar(at)enterprisedb(dot)com> |
---|---|
To: | Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com> |
Cc: | Khushboo Vashi <khushboo(dot)vashi(at)enterprisedb(dot)com>, Murtuza Zabuawala <murtuza(dot)zabuawala(at)enterprisedb(dot)com>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: [pgAdmin4[RM#3948] Fix backform note control style |
Date: | 2019-02-01 13:23:03 |
Message-ID: | CAH4-4WtwHzY+QmCb6f9Dwy+S1qXgRj5J=JNSXUHnY5JxuWR+yg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Ashesh,
It remains same with the white background because the note icon itself
enough to grab the attention of the user.
I have attached the design sample as well.
[image: with-patch.png]
---
Chethana kumar
On Fri, Feb 1, 2019 at 6:45 PM Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com>
wrote:
> On Fri, Feb 1, 2019 at 6:42 PM Chethana Kumar <
> chethana(dot)kumar(at)enterprisedb(dot)com> wrote:
>
>> Hi Khushboo and Murtuza,
>>
>> I have attached the improved version of the design, please share your
>> views.
>> A '*note*' text should be always be highlighted rather than keeping it
>> muted (faded coloured text).
>>
> Chethana,
>
> Can you please send the color combination, when the note control is
> appeared under a subnode control (with white background color)?
>
> -- Thanks, Ashesh
>
>>
>> ---
>> Chethana kumar
>> [image: Existing_design.png]
>>
>>
>>
>> On Wed, Jan 30, 2019 at 4:39 PM Khushboo Vashi <
>> khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:
>>
>>> Hi Murtuza,
>>>
>>> I have reviewed your patch and I feel we need Chethana's suggestion on
>>> this.
>>>
>>> @ Chethana,
>>>
>>> Please have a look the attached screen-shots (Existing_design and
>>> Proposed_design). With this patch the *Note* section design has been
>>> changed.
>>> We need your suggestion on this to improve it as I feel it needs
>>> improvement.
>>>
>>> Thanks,
>>> Khushboo
>>>
>>>
>>> On Wed, Jan 30, 2019 at 3:52 PM Murtuza Zabuawala <
>>> murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
>>>
>>>> Hi,
>>>>
>>>> PFA minor patch to fix the style, changed the background colour and
>>>> text colour so that it can be readable.
>>>>
>>>> --
>>>> Regards,
>>>> Murtuza Zabuawala
>>>> EnterpriseDB: http://www.enterprisedb.com
>>>> The Enterprise PostgreSQL Company
>>>>
>>>>
>>
>> --
>> Chethana Kumar
>> Principal UI/UX Designer
>> EnterpriseDB Corporation
>>
>>
>> The Postgres Database Company
>>
>> P: +91 86981 57146
>> www.enterprisedb.com
>>
>
--
Chethana Kumar
Principal UI/UX Designer
EnterpriseDB Corporation
The Postgres Database Company
P: +91 86981 57146
www.enterprisedb.com
From | Date | Subject | |
---|---|---|---|
Next Message | Aditya Toshniwal | 2019-02-01 13:33:47 | [pgAdmin4][RM3941] Dashboard graphs needs optimizations |
Previous Message | Ashesh Vashi | 2019-02-01 13:15:07 | Re: [pgAdmin4[RM#3948] Fix backform note control style |