From: | Rahila Syed <rahilasyed90(at)gmail(dot)com> |
---|---|
To: | Anastasia Lubennikova <a(dot)lubennikova(at)postgrespro(dot)ru> |
Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, Pavel Borisov <pashkin(dot)elfe(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Amul Sul <sulamul(at)gmail(dot)com> |
Subject: | Re: [PATCH] Automatic HASH and LIST partition creation |
Date: | 2020-09-30 19:58:28 |
Message-ID: | CAH2L28v_fmXvDF+UzMDCObgd7nuqSU=HAJPfw7w4TMx5HGv5ig@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hi Anastasia,
I tested the syntax with some basic commands and it works fine, regression
tests also pass.
Couple of comments:
1. The syntax used omits the { IMMEDIATE | DEFERRED} keywords suggested in
the earlier discussions. I think it is intuitive to include IMMEDIATE with
the current implementation
so that the syntax can be extended with a DEFERRED clause in future for
dynamic partitions.
> CREATE TABLE tbl_lst (i int) PARTITION BY LIST (i)
> CONFIGURATION (values in (1, 2), (3, 4) DEFAULT PARTITION tbl_default);
2. One suggestion for generation of partition names is to append a unique
id to
avoid conflicts.
3. Probably, here you mean to write list and hash instead of range and list
as
per the current state.
<para>
> Range and list partitioning also support automatic creation of
> partitions
> with an optional <literal>CONFIGURATION</literal> clause.
> </para>
4. Typo in default_part_name
+VALUES IN ( <replaceable
> class="parameter">partition_bound_expr</replaceable> [, ...] ), [(
> <replaceable class="parameter">partition_bound_expr</replaceable> [, ...]
> )] [, ...] [DEFAULT PARTITION <replaceable
> class="parameter">defailt_part_name</replaceable>]
> +MODULUS <replaceable class="parameter">numeric_literal</replaceable>
Thank you,
Rahila Syed
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2020-09-30 20:20:16 | Re: BUG #16419: wrong parsing BC year in to_date() function |
Previous Message | Tom Lane | 2020-09-30 19:47:26 | Re: __pg_log_level in anonynous enum should be initialized? (Was: pgsql: Change SHA2 implementation based on OpenSSL to use EVP digest ro) |