| From: | Rahila Syed <rahilasyed90(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Add pg_get_injection_points() for information of injection points |
| Date: | 2025-04-28 16:40:09 |
| Message-ID: | CAH2L28tDJSb3eF=dU_LWAS6qM3Ta2u4U5sezOT1Qdtbswwdirw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Michael,
Thank you for the updated patches.
> Would it be useful to put the logic of the above function under #define
> > USE_INJECTION_POINT. This approach would make it possible to
> > distinguish between cases where no injection points are attached and
> > instances where the build does not support injection points.
>
> For this one, I've found that InjectionPointList() was the incorrect
> bit: we can make it issue an elog(ERROR) if !USE_INJECTION_POINTS.
> This way, none of its callers will be confused between the case of a
> NIL List meaning either !USE_INJECTION_POINTS or that there are no
> points attached if the build uses USE_INJECTION_POINTS.
>
The changes LGTM.
Should the execution privileges on the function be restricted to a role
like pg_monitor?
Thank you,
Rahila Syed
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Álvaro Herrera | 2025-04-28 16:56:37 | Re: Doc: fix the rewrite condition when executing ALTER TABLE ADD COLUMN |
| Previous Message | Masahiko Sawada | 2025-04-28 16:34:05 | Re: Fix premature xmin advancement during fast forward decoding |