Re: pgsql: Delay commit status checks until freezing executes.

From: Peter Geoghegan <pg(at)bowt(dot)ie>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: pgsql: Delay commit status checks until freezing executes.
Date: 2023-01-04 05:50:48
Message-ID: CAH2-WznzR6+i9kq-=EGQhLFbw+eE0+zRxi+5_2LubyUKkEyjpw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On Tue, Jan 3, 2023 at 8:29 PM Peter Geoghegan <pg(at)bowt(dot)ie> wrote:
> I find this astonishing. Why isn't there a prominent comment that
> advertises that TransactionIdDidAbort() just doesn't work reliably?

I pushed a fix for this now.

We should add a comment about this issue to TransactionIdDidAbort()
header comments, but I didn't do that part yet.

Thanks for the report.
--
Peter Geoghegan

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Andres Freund 2023-01-04 06:33:25 Re: pgsql: Delay commit status checks until freezing executes.
Previous Message Peter Geoghegan 2023-01-04 05:49:13 pgsql: Check that xmax didn't commit in freeze check.

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2023-01-04 05:55:31 Re: [PATCH] Improve ability to display optimizer analysis using OPTIMIZER_DEBUG
Previous Message Masahiko Sawada 2023-01-04 05:31:25 Re: Perform streaming logical transactions by background workers and parallel apply