| From: | Peter Geoghegan <pg(at)bowt(dot)ie> |
|---|---|
| To: | Peter Geoghegan <pg(at)bowt(dot)ie>, Andres Freund <andres(at)anarazel(dot)de>, pgsql-hackers(at)postgresql(dot)org, Robert Haas <robertmhaas(at)gmail(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
| Subject: | Re: Show various offset arrays for heap WAL records |
| Date: | 2023-04-11 00:39:12 |
| Message-ID: | CAH2-Wznr-CkJ9WYWRXJQfDH9xRBnhVyC7OV0jDob23_u7Tox7A@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Apr 10, 2023 at 5:23 PM Melanie Plageman
<melanieplageman(at)gmail(dot)com> wrote:
> If you keep the name, I'd explain it briefly in a comment above the code
> then -- for those of us who spend less time with btrees. It is a tool
> that will be often used by developers, so it is not unreasonable to
> assume they may read the code if they are confused.
Okay, I'll do something about that shortly.
Attached v2 deals with the "trailing comma and space in flags array"
heap desc issue using an approach that's along the same lines as your
suggested approach. What do you think?
--
Peter Geoghegan
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-Fix-heapdesc-infomask-array-output.patch | application/octet-stream | 9.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2023-04-11 01:55:26 | Re: Direct I/O |
| Previous Message | Melanie Plageman | 2023-04-11 00:23:15 | Re: Show various offset arrays for heap WAL records |