| From: | Melanie Plageman <melanieplageman(at)gmail(dot)com> |
|---|---|
| To: | Peter Geoghegan <pg(at)bowt(dot)ie> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, pgsql-hackers(at)postgresql(dot)org, Robert Haas <robertmhaas(at)gmail(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
| Subject: | Re: Show various offset arrays for heap WAL records |
| Date: | 2023-04-11 00:23:15 |
| Message-ID: | 20230411002315.oyaicmcqrq2hb3ek@liskov |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Apr 10, 2023 at 04:31:44PM -0700, Peter Geoghegan wrote:
> On Mon, Apr 10, 2023 at 3:04 PM Melanie Plageman <melanieplageman(at)gmail(dot)com> wrote:
> >
> > I will say that the prefix of p in "ptid" makes it sound like pointer to
> > a tid, which I don't believe is what you meant.
>
> I was thinking of the symbol name "ptid" from
> _bt_delitems_delete_check() (it even appears in code comments). I
> intended "posting list TID". But "pointer to a TID" actually kinda
> works too, since these are offsets into a posting list (a simple
> ItemPointerData array) for those TIDs that we're in the process of
> removing/deleted from the tuple.
If you keep the name, I'd explain it briefly in a comment above the code
then -- for those of us who spend less time with btrees. It is a tool
that will be often used by developers, so it is not unreasonable to
assume they may read the code if they are confused.
- Melanie
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Geoghegan | 2023-04-11 00:39:12 | Re: Show various offset arrays for heap WAL records |
| Previous Message | Melanie Plageman | 2023-04-11 00:16:12 | Re: Should vacuum process config file reload more often |