Re: Assign TupleTableSlot->tts_tableOid duplicated in tale AM.

From: Peter Geoghegan <pg(at)bowt(dot)ie>
To: Wenchao Zhang <zwcpostgres(at)gmail(dot)com>
Cc: andres <andres(at)anarazel(dot)de>, pgsql-hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, dilipbalaut <dilipbalaut(at)gmail(dot)com>
Subject: Re: Assign TupleTableSlot->tts_tableOid duplicated in tale AM.
Date: 2022-09-28 02:46:38
Message-ID: CAH2-WznV1iVxW7+TKNKBpqRPVy-XwKu-XmT7dZ5sO7rARFFJgg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Sep 20, 2022 at 11:51 PM Wenchao Zhang <zwcpostgres(at)gmail(dot)com> wrote:
> We can get the two assigned values are same by reading codes. Maybe we should remove one?
>
> What's more, we find that maybe we assign slot->tts_tableOid in outer interface like table_scan_getnextslot may be better and more friendly when we import other pluggable storage formats.

I suppose that you're right; it really should happen in exactly one
place, based on some overarching theory about how tts_tableOid works
with the table AM interface. I just don't know what that theory is.

--
Peter Geoghegan

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2022-09-28 02:52:42 Re: Strip -mmacosx-version-min options from plperl build
Previous Message Andres Freund 2022-09-28 02:27:24 meson vs mingw, plpython, readline and other fun