| From: | Peter Geoghegan <pg(at)bowt(dot)ie> |
|---|---|
| To: | Jeff Davis <pgsql(at)j-davis(dot)com> |
| Cc: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, David Rowley <dgrowleyml(at)gmail(dot)com>, Stephen Frost <sfrost(at)snowman(dot)net>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andres Freund <andres(at)anarazel(dot)de>, Bruce Momjian <bruce(at)momjian(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, Melanie Plageman <melanieplageman(at)gmail(dot)com>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Default setting for enable_hashagg_disk |
| Date: | 2020-07-28 00:55:16 |
| Message-ID: | CAH2-WznK_HnWe=4Y6kVKs3+yhEyTFBXWmHPY1x-J2-8=rhWNLw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-docs pgsql-hackers |
On Mon, Jul 27, 2020 at 5:10 PM Jeff Davis <pgsql(at)j-davis(dot)com> wrote:
> I noticed that one of the conditionals, "cheapest_total_path != NULL",
> was already redundant with the outer conditional before your patch. I
> guess that was just a mistake which your patch corrects along the way?
Makes sense.
> Anyway, the patch looks good to me. We can have a separate discussion
> about pessimizing the costing, if necessary.
Pushed the hashagg_avoid_disk_plan patch -- thanks!
--
Peter Geoghegan
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jeff Davis | 2020-07-29 17:13:23 | Re: Default setting for enable_hashagg_disk |
| Previous Message | Jeff Davis | 2020-07-28 00:10:41 | Re: Default setting for enable_hashagg_disk |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2020-07-28 01:10:33 | Re: expose parallel leader in CSV and log_line_prefix |
| Previous Message | David Rowley | 2020-07-28 00:54:35 | Re: HashAgg's batching counter starts at 0, but Hash's starts at 1. |