Re: pgsql: Add wait event for fsync of WAL segments

From: Peter Geoghegan <pg(at)bowt(dot)ie>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Michael Paquier <michael(at)paquier(dot)xyz>, Julien Rouhaud <rjuju123(at)gmail(dot)com>, pgsql-committers <pgsql-committers(at)lists(dot)postgresql(dot)org>
Subject: Re: pgsql: Add wait event for fsync of WAL segments
Date: 2018-07-09 19:12:42
Message-ID: CAH2-WznKQpcUACGvv+Odsjy-O0hUxcOp0H6FrqzQSM5FKu+89A@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On Mon, Jul 9, 2018 at 11:24 AM, Alvaro Herrera
<alvherre(at)2ndquadrant(dot)com> wrote:
> Maybe we should add an XML comment
> <!-- remember to update "morerows" above -->
> at the end of the table :-)

+1. I made the same mistake at one point.

--
Peter Geoghegan

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Andres Freund 2018-07-09 20:39:15 Re: pgsql: Fix crash when ALTER TABLE recreates indexes on partitions
Previous Message Alvaro Herrera 2018-07-09 18:34:39 pgsql: Flip argument order in XLogSegNoOffsetToRecPtr

Browse pgsql-hackers by date

  From Date Subject
Next Message Tomas Vondra 2018-07-09 19:21:37 Re: [PATCH] Improve geometric types
Previous Message Alvaro Herrera 2018-07-09 18:57:24 Re: no partition pruning when partitioning using array type