Re: Further _bt_first simplifications for parallel index scans

From: Peter Geoghegan <pg(at)bowt(dot)ie>
To: Matthias van de Meent <boekewurm+postgres(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Further _bt_first simplifications for parallel index scans
Date: 2025-01-07 15:30:57
Message-ID: CAH2-WznBkGSseaaUiDU3a2qyD5dOonChuXc5_3e8AdBw+eBz3Q@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Jan 7, 2025 at 6:56 AM Matthias van de Meent
<boekewurm+postgres(at)gmail(dot)com> wrote:
> Apart from comments on comment contents and placement, no specific issues:

Pushed this just now. Thanks for the review!

> > + *
> > + * Initialize arrays during first (unscheduled) primitive index scan.
> > + */
>
> I think this could be more clear about why these conditions indicate
> the first unscheduled primitive index scan.

Improved this in the committed patch.

> I don't understand the placement of that comment, as it's quite far
> away from any parallel scan related code and it's very unrelated to
> the index scan statistics.
> If this needs to be added, I think I'd put it next to the call to
> _bt_parallel_seize().

Done that way in the committed patch.

--
Peter Geoghegan

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Geoghegan 2025-01-07 15:39:44 Re: More reliable nbtree detection of unsatisfiable RowCompare quals involving a leading NULL key/element
Previous Message Tom Lane 2025-01-07 15:26:51 Re: Temporary Views Cleanup Issue