| From: | Peter Geoghegan <pg(at)bowt(dot)ie> |
|---|---|
| To: | Jeff Davis <pgsql(at)j-davis(dot)com> |
| Cc: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: logtape.c stats don't account for unused "prefetched" block numbers |
| Date: | 2020-09-14 21:24:54 |
| Message-ID: | CAH2-Wzn6pGXE-0vwwVbGZ--+qACd8D0ArqfZx7k05XaibAaFrQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Sep 11, 2020 at 6:37 PM Peter Geoghegan <pg(at)bowt(dot)ie> wrote:
> It would be awkward if we just used nBlocksWritten within
> LogicalTapeSetBlocks() in the case where we didn't preallocate (or in
> all cases). Not entirely sure what to do about that just yet.
I guess that that's the logical thing to do, as in the attached patch.
What do you think, Jeff?
--
Peter Geoghegan
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-LogicalTapeSetBlocks-issue-Tentative-fix.patch | application/octet-stream | 2.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Thomas Munro | 2020-09-14 21:56:16 | Re: Division in dynahash.c due to HASH_FFACTOR |
| Previous Message | Andres Freund | 2020-09-14 21:05:22 | Re: Allow ERROR from heap_prepare_freeze_tuple to be downgraded to WARNING |