| From: | Peter Geoghegan <pg(at)bowt(dot)ie> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [HACKERS] ginInsertCleanup called from vacuum could still miss tuples to be deleted |
| Date: | 2017-11-16 20:34:50 |
| Message-ID: | CAH2-Wzn53YaF9sF-EBNHzVbCnguHEP9P31K8WRWfY0CRGA5Rig@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Nov 16, 2017 at 12:29 PM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> I am also clear on what the consequences of this bug are. It seems
> like it could harm insert performance by making us wait when we
> shouldn't, but can it cause corruption? That I'm not sure about. If
> there's already a cleanup of the pending list in progress, how do
> things go wrong?
While it was probably the right thing for you to go ahead and commit
the patch, I think that the bug undermines whatever confidence there
was in the correctness of the GIN pending list cleanup code. I have
far more questions than answers right now, though.
--
Peter Geoghegan
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2017-11-16 20:36:26 | Re: [HACKERS] Remove duplicate setting in test/recovery/Makefile |
| Previous Message | Robert Haas | 2017-11-16 20:29:08 | Re: [HACKERS] ginInsertCleanup called from vacuum could still miss tuples to be deleted |