| From: | Peter Geoghegan <pg(at)bowt(dot)ie> |
|---|---|
| To: | Tomas Vondra <tomas(at)vondra(dot)me> |
| Cc: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Fix for pageinspect bug in PG 17 |
| Date: | 2024-11-13 17:20:57 |
| Message-ID: | CAH2-Wzn+6MGAA7jLVBLWQ7HSr-R6Haf7HsOxo8wvN2cFtjsYOQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Nov 13, 2024 at 11:07 AM Tomas Vondra <tomas(at)vondra(dot)me> wrote:
> My plan was to apply the patch to both 17 and HEAD, and then maybe do
> something smarter in HEAD in a separate commit. But then Michael pointed
> out other pageinspect functions just error out in this version-mismatch
> cases, so I think it's better to just do it the same way.
FWIW I didn't actually backpatch commit 691e8b2e18. I decided that it
was better to just paper-over the issue on backbranches instead -- see
commit c788115b.
The problem that I fixed back in 2020 was a problem with the data
types used -- not a failure to consider older versions of the
extension at all. It was just convenient to use the number of columns
to detect the version of the extension to detect a problematic
(incorrectly typed) function.
--
Peter Geoghegan
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Masahiko Sawada | 2024-11-13 17:58:10 | Re: Skip collecting decoded changes of already-aborted transactions |
| Previous Message | Emanuele Musella | 2024-11-13 16:54:56 | Re: Parametrization minimum password lenght |