From: | Peter Geoghegan <pg(at)bowt(dot)ie> |
---|---|
To: | Justin Pryzby <pryzby(at)telsasoft(dot)com> |
Cc: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Georgios Kokolatos <gkokolatos(at)pm(dot)me>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Tatsuro Yamada <tatsuro(dot)yamada(dot)tf(at)nttcom(dot)co(dot)jp> |
Subject: | Re: v13: show extended stats target in \d |
Date: | 2020-09-07 21:31:07 |
Message-ID: | CAH2-WzmzzTPfR7bpcdSJhkswvqF_4A6Me41-p0oz+=kMrMZ6Qw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Sun, Sep 6, 2020 at 1:48 PM Justin Pryzby <pryzby(at)telsasoft(dot)com> wrote:
> On Sun, Sep 06, 2020 at 01:06:05PM -0700, Peter Geoghegan wrote:
> > How about a line break? That seems like a simple solution that takes
> > all the competing concerns into account.
> Like this ?
> Statistics objects:
> "public"."t" (ndistinct, dependencies, mcv) ON a, b FROM t
No, not like that.
ISTM that the problem with your original proposal is that it suggests
that it ought to be possible to add "STATISTICS 0" to the end of a
CREATE STATISTICS statement. That's not accurate, though. In reality
the only way to set the statistics target for a statistics object is
with ALTER STATISTICS. We should attempt to convey that difference
here.
More concretely, I was suggesting including a second line that's
similar to the following example output (iff the statistics target has
actually been set):
Statistics objects:
"public"."t" (ndistinct, dependencies, mcv) ON a, b FROM t
(STATISTICS 0)
Maybe some variation would be better -- the precise details are not
important. The new line conveys the fact that STATISTICS 0 is a part
of the object, but cannot appear in CREATE STATISTICS itself. That
seems like the right way of framing this.
--
Peter Geoghegan
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2020-09-07 22:00:54 | Re: [PATCH] audo-detect and use -moutline-atomics compilation flag for aarch64 |
Previous Message | Jeff Davis | 2020-09-07 20:55:28 | Re: Disk-based hash aggregate's cost model |