Re: pgsql: pgstat: run pgindent on pgstat.c/h.

From: Peter Geoghegan <pg(at)bowt(dot)ie>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: pgsql-committers <pgsql-committers(at)lists(dot)postgresql(dot)org>
Subject: Re: pgsql: pgstat: run pgindent on pgstat.c/h.
Date: 2022-03-19 19:36:29
Message-ID: CAH2-WzmuFCFg+FX31Z_Qz1cxdzV0RDK491fgB-hg-=4DJsAdww@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On Sat, Mar 19, 2022 at 12:27 PM Andres Freund <andres(at)anarazel(dot)de> wrote:
> I was actually wondering what our policy around that is for smaller runs like
> this. Do we do that in bulk occasionally? Just after?

That's not completely clear, but I think that it makes sense to do it
right afterwards. We haven't been maintaining a .git-blame-ignore-revs
file for long enough, so maybe the workflow needs to be refined. Perhaps there
should *also* be something in the RELEASE_CHANGES files about looking
for overlooked pgindent files, too.

It's not the end of the world if somebody forgets to do this,
obviously. Ideally there would be some kind of reminder built into the
pgindent tooling to make it less likely.

> We're also missing the recent, a bit larger, reindent that Heikki did:

> Run pgindent on xlog.c.

I missed that one.

--
Peter Geoghegan

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Andres Freund 2022-03-19 19:40:54 pgsql: Add a few recent and not so recent revs to git-blame-ignore-revs
Previous Message Andres Freund 2022-03-19 19:27:15 Re: pgsql: pgstat: run pgindent on pgstat.c/h.