Re: Avoid a possible overflow (src/backend/utils/sort/logtape.c)

From: Peter Geoghegan <pg(at)bowt(dot)ie>
To: David Rowley <dgrowleyml(at)gmail(dot)com>
Cc: Michael Paquier <michael(at)paquier(dot)xyz>, Ranier Vilela <ranier(dot)vf(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Avoid a possible overflow (src/backend/utils/sort/logtape.c)
Date: 2023-08-25 02:02:40
Message-ID: CAH2-WzmsXA4EXk9SCBhLAjxJsw87SoZ0fs61C6Dt4SvgtbR+yg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Aug 24, 2023 at 6:44 PM David Rowley <dgrowleyml(at)gmail(dot)com> wrote:
> I agree with this. I think Ranier's patch is good and we should apply
> it and backpatch it.

FWIW I'm pretty sure that it's impossible to run into problems here in
practice -- the minheap is allocated by palloc(), and the high
watermark number of free pages is pretty small. Even still, I agree
with your conclusion. There is really no reason to not be consistent
here.

--
Peter Geoghegan

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Hayato Kuroda (Fujitsu) 2023-08-25 02:09:38 RE: [PoC] pg_upgrade: allow to upgrade publisher node
Previous Message Peter Geoghegan 2023-08-25 01:55:00 Re: Avoid a possible overflow (src/backend/utils/sort/logtape.c)