Re: [PATCH] Fix possible underflow in expression (maxoff - 1)

From: Peter Geoghegan <pg(at)bowt(dot)ie>
To: Ranier Vilela <ranier_gyn(at)hotmail(dot)com>
Cc: "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] Fix possible underflow in expression (maxoff - 1)
Date: 2019-11-24 20:11:12
Message-ID: CAH2-WzmgLfXSa1sX5dHDKM+JEg=qSmqLKqF8U2DrdqMZuaM2RA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sun, Nov 24, 2019 at 12:02 PM Ranier Vilela <ranier_gyn(at)hotmail(dot)com> wrote:
> I've been programming in C for a long time, and I'm getting better every day, I believe.
> I'll arrive there.

If you don't understand the *specific* C code in question, you're
unlikely to successfully diagnose a problem with the C code.
Regardless of your general ability as a C programmer. It is necessary
to understand the data structures in question, and how they're used
and expected to work. Their invariants.

> >I strongly suggest confining all of this to a single thread, and
> >stating your reasoning upfront.
> I don't know what that means.

Instead of starting new email threads for each issue, confine the
entire discussion to just one thread. This makes the discussion much
more manageable for everyone else. This is a high traffic mailing
list.

--
Peter Geoghegan

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Thomas Munro 2019-11-24 20:29:25 Re: Minor white space typo in documentation
Previous Message Ranier Vilela 2019-11-24 20:02:50 RE: [PATCH] Fix possible underflow in expression (maxoff - 1)