Re: pgsql: Avoid improbable PANIC during heap_update.

From: Peter Geoghegan <pg(at)bowt(dot)ie>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Jaime Casanova <jcasanov(at)systemguards(dot)com(dot)ec>, pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Avoid improbable PANIC during heap_update.
Date: 2022-09-30 22:03:46
Message-ID: CAH2-Wzmb3ENhfaLVv=+TwQyHSbUxvhsOPWo7Lsw7o-1kUbpzXw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On Fri, Sep 30, 2022 at 2:56 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> > FWIW it seems possible that the Postgres 15 vacuumlazy.c work that
> > added lazy_scan_noprune() made this scenario more likely in practice
> > -- even compared to Postgres 14.
>
> Could be, because we haven't seen field reports of this in v14 yet.

I would be more confident here were it not for the recent
heap_delete() issue reported by one of my AWS colleagues (and fixed by
another, Jeff Davis). See commit 163b0993 if you missed it before now.

> And there's still no hard evidence of a bug pre-14. Nonetheless,
> I'm inclined to backpatch to v12 as 34f581c39 was.

+1

--
Peter Geoghegan

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2022-09-30 23:37:19 pgsql: Avoid improbable PANIC during heap_update, redux.
Previous Message Tom Lane 2022-09-30 21:56:11 Re: pgsql: Avoid improbable PANIC during heap_update.

Browse pgsql-hackers by date

  From Date Subject
Next Message Benjamin Coutu 2022-09-30 22:19:16 Re: disfavoring unparameterized nested loops
Previous Message Tom Lane 2022-09-30 22:00:53 Re: predefined role(s) for VACUUM and ANALYZE