Re: New IndexAM API controlling index vacuum strategies

From: Peter Geoghegan <pg(at)bowt(dot)ie>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Noah Misch <noah(at)leadboat(dot)com>, Matthias van de Meent <boekewurm+postgres(at)gmail(dot)com>
Subject: Re: New IndexAM API controlling index vacuum strategies
Date: 2021-04-06 00:09:02
Message-ID: CAH2-WzmXeJJhafhn8smfNOMYOr4MTtz=DAHJeAHhviRdz7-+cA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Apr 5, 2021 at 5:00 PM Andres Freund <andres(at)anarazel(dot)de> wrote:
> What do you mean with "appear to work"? Isn't, in 13, the only
> consequence of vac_strategy not being "propagated" that we'll not use a
> strategy in parallel workers? Presumably that was hard to notice
> because most people don't run manual VACUUM with cost limits turned
> on. And autovacuum doesn't use parallelism.

Oh yeah. "static BufferAccessStrategy vac_strategy" is guaranteed to
be initialized to 0, simply because it's static and global. That
explains it.

--
Peter Geoghegan

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message osumi.takamichi@fujitsu.com 2021-04-06 00:13:57 RE: Stronger safeguard for archive recovery not to miss data
Previous Message Andres Freund 2021-04-06 00:00:31 Re: New IndexAM API controlling index vacuum strategies