Re: visibility map corruption

From: Peter Geoghegan <pg(at)bowt(dot)ie>
To: Mark Dilger <mark(dot)dilger(at)enterprisedb(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Bruce Momjian <bruce(at)momjian(dot)us>, Floris Van Nee <florisvannee(at)optiver(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: visibility map corruption
Date: 2021-07-06 22:20:23
Message-ID: CAH2-WzmTVh1Ewuoj_uiQ6YGcK441YtFwAZ23+U0wuG5MgdJSug@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Jul 6, 2021 at 3:12 PM Mark Dilger <mark(dot)dilger(at)enterprisedb(dot)com> wrote:
> Thanks, Peter, for drawing my attention to this. I had already been following this thread, but had not yet thought about the problem in terms of amcheck.
>
> I will investigate possible solutions in verify_heapam().

Thanks! Great that we might be able to make a whole class of bugs
detectable with the new amcheck stuff. Glad that I didn't forget about
amcheck myself -- I almost forgot.

When I was working on the btree amcheck code, I looked for interesting
historical bugs and made sure that I could detect them. That seems
even more important with heapam. I wouldn't be surprised if one or two
important invariants were missed, in part because the heapam design
didn't have invariants as a starting point.

--
Peter Geoghegan

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2021-07-06 22:30:41 Re: visibility map corruption
Previous Message Gilles Darold 2021-07-06 22:18:31 [PATCH][postgres_fdw] Add push down of CASE WHEN clauses