Re: The unused_oids script should have a reminder to use the 8000-8999 OID range

From: Peter Geoghegan <pg(at)bowt(dot)ie>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Julien Rouhaud <rjuju123(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: The unused_oids script should have a reminder to use the 8000-8999 OID range
Date: 2019-08-02 22:42:29
Message-ID: CAH2-WzmRkEP7Koa4CEpaaqgB089PVvNsBhM2ssyiniPsBLm-yw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Aug 2, 2019 at 3:19 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> The "if ($oid > $prev_oid + 2)" test seems unnecessary.
> It's certainly wrong to keep iterating beyond the first
> oid that's > $suggestion.

Sorry. That was just carelessness on my part. (Being the world's worst
Perl programmer is no excuse.)

How about the attached? I've simply removed the "if ($oid > $prev_oid
+ 2)" test.

--
Peter Geoghegan

Attachment Content-Type Size
v4-0001-unused_oids-suggestion.patch application/octet-stream 1.3 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2019-08-02 22:42:51 Re: tableam vs. TOAST
Previous Message Tom Lane 2019-08-02 22:39:50 Re: jsonb_plperl bug