| From: | Peter Geoghegan <pg(at)bowt(dot)ie> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>, Pavan Deolasee <pavan(dot)deolasee(at)gmail(dot)com>, Etsuro Fujita <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp>, Andres Freund <andres(at)anarazel(dot)de>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: ON CONFLICT DO UPDATE for partitioned tables |
| Date: | 2018-04-19 19:21:40 |
| Message-ID: | CAH2-WzmPZUb68f4hvDGgZBKJ2KMdvaJRwwfYH=5EHUOrzKuK0w@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Apr 19, 2018 at 12:00 PM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> On Thu, Apr 19, 2018 at 1:20 PM, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> wrote:
>> How about simply relaxing the tdtypeid test from equalTupleDescs? I
>> haven't looked deeply but I think just checking whether or not both are
>> RECORDOID might be sufficient, for typecache purposes.
>
> That strike me as a very scary thing to do. There's code all over the
> system that may have non-obvious assumptions about the behavior of
> equalTupleDescs(), and I don't think we can have any confidence that
> nothing will break unless we do a detailed audit of all that code.
+1. I think that it is plainly a bad idea to do something like that at
this point in the cycle.
--
Peter Geoghegan
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2018-04-19 19:40:17 | Re: ON CONFLICT DO UPDATE for partitioned tables |
| Previous Message | Heikki Linnakangas | 2018-04-19 19:15:30 | Re: initdb fails to initialize data directory |