Re: pgstat_report_activity() and parallel CREATE INDEX (was: Parallel index creation & pg_stat_activity)

From: Peter Geoghegan <pg(at)bowt(dot)ie>
To: Noah Misch <noah(at)leadboat(dot)com>
Cc: Andres Freund <andres(at)anarazel(dot)de>, Phil Florent <philflorent(at)hotmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pgstat_report_activity() and parallel CREATE INDEX (was: Parallel index creation & pg_stat_activity)
Date: 2020-10-17 15:39:35
Message-ID: CAH2-Wzm2K3jqurvFfCXsV=s+NvPf9V=6YDDcVPk-0kORL9D7oA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Oct 13, 2020 at 7:26 PM Noah Misch <noah(at)leadboat(dot)com> wrote:
> 1. Disable parallelism for the index build under ExecuteTruncateGuts().
> Nobody will mourn a performance loss from declining parallelism for an
> empty index, but I feel like this is fixing in the wrong place.
> 2. Make _bt_begin_parallel() and begin_parallel_vacuum() recognize the
> debug_query_string==NULL case and reproduce it on the worker.
> 3. Require bgworkers to set debug_query_string before entering code of vacuum,
> truncate, etc. Logical replication might synthesize a DDL statement, or it
> might just use a constant string.
>
> I tend to prefer (2), but (3) isn't bad. Opinions?

I also prefer 2.

Thanks
--
Peter Geoghegan

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2020-10-17 15:50:57 Re: Sometimes the output to the stdout in Windows disappears
Previous Message David G. Johnston 2020-10-17 15:11:34 Re: [PATCH] Add extra statistics to explain for Nested Loop