On Thu, Apr 18, 2019 at 5:46 PM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
> Adding an open item is adapted, nice you found this issue. Testing on
> my laptop with v11, the non-NULL case takes 5s and the NULL case 6s.
> On HEAD, the non-NULL case takes 6s, and the NULL case takes... I
> just gave up and cancelled it :)
This was one of those things that occurred to me out of the blue.
It just occurred to me that the final patch will need to be more
careful about non-key attributes in INCLUDE indexes. It's not okay for
it to avoid calling _bt_check_unique() just because a non-key
attribute was NULL. It should only do that when a key attribute is
NULL.
--
Peter Geoghegan