Re: master check fails on Windows Server 2008

From: Peter Geoghegan <pg(at)bowt(dot)ie>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Marina Polyakova <m(dot)polyakova(at)postgrespro(dot)ru>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Subject: Re: master check fails on Windows Server 2008
Date: 2018-02-20 01:21:12
Message-ID: CAH2-Wzm2FkneQHr7PzHuqQOLffcWNrrr2ExvH-RBEDA8U_6g5A@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Feb 19, 2018 at 4:37 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> I see several things we could do about this:
>
> 1. Nothing; just say "sorry, we don't promise that the regression tests
> pass with no plan differences on nonstandard configurations". Given that
> --disable-float8-byval has hardly any real-world use, there is not a lot
> of downside to that.

That would make sense to me. It will also be necessary to formalize
what "nonstandard configuration" actually means if we go this way, of
course.

I believe that this is already true with "dynamic_shared_memory_type
== DSM_IMPL_NONE", so that's a second entry for the "nonstandard
configuration" list.

--
Peter Geoghegan

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Masahiko Sawada 2018-02-20 01:47:39 Typo in procarray.c
Previous Message Tsunakawa, Takayuki 2018-02-20 01:09:37 RE: Changing default value of wal_sync_method to open_datasync on Linux