| From: | Peter Geoghegan <pg(at)bowt(dot)ie> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Justin Pryzby <pryzby(at)telsasoft(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Removing more vacuumlazy.c special cases, relfrozenxid optimizations |
| Date: | 2022-04-05 03:25:44 |
| Message-ID: | CAH2-Wzm1rEsYXYYg4+1Oj-kwTmsgKKm1wxeu=+JsdYUHgd+AuA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Apr 4, 2022 at 8:18 PM Andres Freund <andres(at)anarazel(dot)de> wrote:
> The remaining patch are the warnings in vac_update_relstats(), correct? I
> guess one could argue they should be LOG rather than WARNING, but I find the
> project stance on that pretty impractical. So warning's ok with me.
Right. The reason I used WARNINGs was because it matches vaguely
related WARNINGs in vac_update_relstats()'s sibling function,
vacuum_set_xid_limits().
> Not sure why you used errmsg_internal()?
The usual reason for using errmsg_internal(), I suppose. I tend to do
that with corruption related messages on the grounds that they're
usually highly obscure issues that are (by definition) never supposed
to happen. The only thing that a user can be expected to do with the
information from the message is to report it to -bugs, or find some
other similar report.
--
Peter Geoghegan
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Masahiko Sawada | 2022-04-05 03:38:49 | Re: Skipping logical replication transactions on subscriber side |
| Previous Message | Andres Freund | 2022-04-05 03:18:02 | Re: Removing more vacuumlazy.c special cases, relfrozenxid optimizations |