| From: | Peter Geoghegan <pg(at)bowt(dot)ie> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Unimpressed with pg_attribute_always_inline |
| Date: | 2018-01-09 00:39:50 |
| Message-ID: | CAH2-Wzm+RH=-SGpZsu+4y0JDj_RQDUbJSvfP13NAzjm90WpAtw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Jan 8, 2018 at 4:22 PM, Andres Freund <andres(at)anarazel(dot)de> wrote:
>> Isn't that an argument against inlining in general, rather than
>> forcing inlining in particular?
>
> No. Normal 'inline' annotation doesn't do anything on -O0 / debug
> builds. But always_inline does, even though the goal of the usage is
> just to override the compiler's inlining heuristics.
Sorry, I found the way this was discussed confusing.
Anyway, ISTM that it should be possible to make
pg_attribute_always_inline have no effect in typical debug builds.
Wouldn't that make everyone happy?
--
Peter Geoghegan
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2018-01-09 00:56:47 | Re: Unimpressed with pg_attribute_always_inline |
| Previous Message | Andres Freund | 2018-01-09 00:22:57 | Re: Unimpressed with pg_attribute_always_inline |