Re: heap_abort_speculative() sets xmin to Invalid* without HEAP_XMIN_INVALID

From: Peter Geoghegan <pg(at)bowt(dot)ie>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: heap_abort_speculative() sets xmin to Invalid* without HEAP_XMIN_INVALID
Date: 2020-07-24 03:51:24
Message-ID: CAH2-Wzkpiu7FVCeLY+TTm97-xrLRmb9uvNkBkg+K0XwSkyaC+g@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Jul 23, 2020 at 2:49 PM Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> wrote:
> On 2020-Jul-23, Andres Freund wrote:
>
> > I think we should change heap_abort_speculative() to set
> > HEAP_XMIN_INVALID in master.
>
> +1

+1

> +1 for doing it as an additional fix, with a fat comment somewhere
> explaining where such tuples would come from.

There could be an opportunity to put this on a formal footing by doing
something in the amcheck heap checker patch.

--
Peter Geoghegan

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Christophe Pettus 2020-07-24 04:01:25 Row estimates for empty tables
Previous Message Tom Lane 2020-07-24 02:34:53 Re: Making CASE error handling less surprising