| From: | Peter Geoghegan <pg(at)bowt(dot)ie> |
|---|---|
| To: | David Rowley <dgrowleyml(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Making C function declaration parameter names consistent with corresponding definition names |
| Date: | 2022-09-20 06:36:35 |
| Message-ID: | CAH2-Wzkn0W2SFtdPk1pFZUPF9vZy82X6D85YTVt2qq3w7hRJug@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sun, Sep 18, 2022 at 9:17 PM Peter Geoghegan <pg(at)bowt(dot)ie> wrote:
> Will fix all those in the next revision. Thanks.
Attached revision v4 fixes those pg_dump patch items.
It also breaks out the ecpg changes into their own patch. Looks like
ecpg requires the same treatment as the timezone code and the regex
code -- it generally doesn't use named parameters in function
declarations, so the majority of its function declarations need to be
adjusted. The overall code churn impact is higher than it was with the
other two modules.
--
Peter Geoghegan
| Attachment | Content-Type | Size |
|---|---|---|
| v4-0002-Harmonize-parameter-names-in-jsonb-code.patch | application/octet-stream | 12.1 KB |
| v4-0004-Harmonize-parameter-names-in-miscellaneous-code.patch | application/octet-stream | 113.3 KB |
| v4-0003-Harmonize-parameter-names-in-ecpg-code.patch | application/octet-stream | 37.1 KB |
| v4-0001-Harmonize-parameter-names-in-pg_dump-pg_dumpall.patch | application/octet-stream | 56.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Langote | 2022-09-20 06:40:55 | Re: missing indexes in indexlist with partitioned tables |
| Previous Message | Thomas Munro | 2022-09-20 06:35:51 | Re: Proposal to use JSON for Postgres Parser format |