| From: | Peter Geoghegan <pg(at)bowt(dot)ie> |
|---|---|
| To: | Justin Pryzby <pryzby(at)telsasoft(dot)com> |
| Cc: | David Rowley <dgrowleyml(at)gmail(dot)com>, James Coleman <jtc331(at)gmail(dot)com>, Jeff Davis <pgsql(at)j-davis(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: HashAgg's batching counter starts at 0, but Hash's starts at 1. (now: incremental sort) |
| Date: | 2020-07-31 01:33:32 |
| Message-ID: | CAH2-Wzkg4irS+D_gD_kArkewXhQiL7SFLtjzxX25JRv4Mw4jow@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Jul 30, 2020 at 5:22 PM Justin Pryzby <pryzby(at)telsasoft(dot)com> wrote:
> Because filtering out zero values is exactly what's intended to be avoided for
> nontext output.
>
> I think checking whether the method was used should result in the same output,
> without the literal check for zero value (which itself sets a bad example).
It seems fine to me as-is. What about SORT_TYPE_TOP_N_HEAPSORT? Or any
other sort methods we add in the future?
The way that we flatten maxDiskSpaceUsed and maxMemorySpaceUsed into
"space used" on output might be kind of questionable, but it's
something that we have to live with for the foreseeable future. I
don't think that this is a bad example -- we don't output
maxDiskSpaceUsed or maxMemorySpaceUsed at the conceptual level.
--
Peter Geoghegan
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Mark Dilger | 2020-07-31 01:38:43 | Re: new heapcheck contrib module |
| Previous Message | Tom Lane | 2020-07-31 01:25:22 | Re: Missing CFI in hlCover()? |