Re: pgsql: Optimize btree insertions for common case of increasing values

From: Peter Geoghegan <pg(at)bowt(dot)ie>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: Pavan Deolasee <pavan(dot)deolasee(at)gmail(dot)com>, pgsql-committers <pgsql-committers(at)lists(dot)postgresql(dot)org>
Subject: Re: pgsql: Optimize btree insertions for common case of increasing values
Date: 2018-04-10 22:33:20
Message-ID: CAH2-Wzkekg9G294UnCJfTZAVpO2US_g+-JQqFmcsZW_y5o6Mcg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On Tue, Apr 10, 2018 at 3:27 PM, Andrew Dunstan <andrew(at)dunslane(dot)net> wrote:
> Committed with light editing. I didn't put the #define in the .h file -
> it's only used here and that seemed like unnecessary clutter. I moved it
> to the top of the file. I also standardized the spelling of "optimization".

The comments still say "Check if the page...no split is in progress".
Despite the fact that that's just an assertion now.

--
Peter Geoghegan

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2018-04-10 22:35:13 pgsql: Fix incorrect close() call in dsm_impl_mmap().
Previous Message Andrew Dunstan 2018-04-10 22:27:10 Re: pgsql: Optimize btree insertions for common case of increasing values