Re: group by true now errors with non-integer constant in GROUP BY

From: Peter Geoghegan <pg(at)bowt(dot)ie>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: David Rowley <dgrowleyml(at)gmail(dot)com>, John Naylor <john(dot)naylor(at)enterprisedb(dot)com>, David Micallef <david(dot)j(dot)micallef(at)gmail(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, pgsql-bugs(at)lists(dot)postgresql(dot)org
Subject: Re: group by true now errors with non-integer constant in GROUP BY
Date: 2023-09-21 04:58:10
Message-ID: CAH2-WzkZLdgYd8gVR-Qw4Mwu6spe1FUwyMxOwPGoW+j3RT90oA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

On Sun, Sep 17, 2023 at 5:01 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> David Rowley <dgrowleyml(at)gmail(dot)com> writes:
> > 2. In master only, remove the special case added in #1 and allow any
> > non-integer constants to be treated as expressions.
>
> > I think #2 is a good move for the following reasons:
>
> FTR, I still think this is a bad idea. It will add more confusion
> than it removes, and I don't buy that it will confer any advantages,
> because nobody asked for it previously.

I agree. Maintaining bug compatibility doesn't seem worth it in this instance.

David Micallef mentioned that only one query was affected. You have to
draw the line somewhere.

--
Peter Geoghegan

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message PG Bug reporting form 2023-09-21 06:31:16 BUG #18123: The execution plan for the left join is incorrect, returning incorrect rows of data.
Previous Message daidewei@highgo.com 2023-09-21 01:22:33 Re: Re: a plpgsql bug