Re: A potential memory leak on Merge Join when Sort node is not below Materialize node

From: Peter Geoghegan <pg(at)bowt(dot)ie>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: David Rowley <dgrowleyml(at)gmail(dot)com>, Ronan Dunklau <ronan(dot)dunklau(at)aiven(dot)io>, Önder Kalacı <onderkalaci(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: A potential memory leak on Merge Join when Sort node is not below Materialize node
Date: 2022-09-28 23:07:23
Message-ID: CAH2-WzkX5Lk31SwC1dVw_B4O4en5mTVsQRf9sRoCYiPyED3bqw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Sep 28, 2022 at 4:00 PM Peter Geoghegan <pg(at)bowt(dot)ie> wrote:
> I am reminded of the discussion that led to bugfix commit c2d4eb1b
> some years back.

Also potentially relevant: the 2017 commit fa117ee4 anticipated adding
a "copy" argument to tuplesort_getdatum() (the same commit added such
a "copy" argument to tuplesort_gettupleslot()). I see that that still
hasn't happened to tuplesort_getdatum() all these years later. Might
be a good idea to do it in the next year or two, though.

If David is interested in pursuing this now then I certainly won't object.

--
Peter Geoghegan

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2022-09-28 23:08:05 Re: problems with making relfilenodes 56-bits
Previous Message Peter Geoghegan 2022-09-28 23:00:04 Re: A potential memory leak on Merge Join when Sort node is not below Materialize node