Re: Maintaining a list of pgindent commits for "git blame" to ignore

From: Peter Geoghegan <pg(at)bowt(dot)ie>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Bruce Momjian <bruce(at)momjian(dot)us>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Maintaining a list of pgindent commits for "git blame" to ignore
Date: 2021-06-21 04:28:15
Message-ID: CAH2-WzkUxD-f1+iG+XvKQR6BdQQeMAxoMNmkC+DQ1YqVs2MmOw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Mar 18, 2021 at 4:32 PM Peter Geoghegan <pg(at)bowt(dot)ie> wrote:
> On Thu, Mar 18, 2021 at 4:05 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> > b5d69b7c22ee4c44b8bb99cfa0466ffaf3b5fab9 # Sun Jun 7 16:57:08 2020 -0400
> > # pgindent run prior to branching v13.
> >
> > which is easy to make from "git log" or "git show" output. (Because
> > of the precedent of those tools, I'd rather write the commit hash
> > before the rest of the entry.)
>
> WFM.

What do you think of the attached? I prefer the ISO date style myself,
so I went with that.

Note that I have included "Modify BufferGetPage() to prepare for
"snapshot too old" feature", as well as "Revert no-op changes to
BufferGetPage()". I've noticed that those two particular commits cause
unhelpful noise when I run "git blame" on access method code. I see
problems with these commits often enough to matter. The latter commit
cleanly reverted the former after only 12 days, so ignoring both seems
okay to me.

Everything else should be either pgindent/perltidy related or
reformat-dat-files related.

--
Peter Geoghegan

Attachment Content-Type Size
pgindent-git-blame-ignore-revs application/octet-stream 6.2 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Sandeep Thakkar 2021-06-21 04:32:44 Re: [PATCH v3 1/1] Fix detection of preadv/pwritev support for OSX.
Previous Message Masahiko Sawada 2021-06-21 03:50:31 Re: Optionally automatically disable logical replication subscriptions on error