Re: pgsql: Add functions to 'pageinspect' to inspect GiST indexes.

From: Peter Geoghegan <pg(at)bowt(dot)ie>
To: Andrey Borodin <x4mmm(at)yandex-team(dot)ru>
Cc: Heikki Linnakangas <heikki(dot)linnakangas(at)iki(dot)fi>, pgsql-committers <pgsql-committers(at)lists(dot)postgresql(dot)org>
Subject: Re: pgsql: Add functions to 'pageinspect' to inspect GiST indexes.
Date: 2021-02-15 04:12:28
Message-ID: CAH2-WzkR08cLLHJrWBGTGF2SwZdChboHTiia_ZU7T7WRAveskA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On Thu, Feb 11, 2021 at 9:22 PM Andrey Borodin <x4mmm(at)yandex-team(dot)ru> wrote:
> Thanks, Peter! I agree that taking PageGetMaxOffsetNumber() seems
> incorrect for deleted page, because we set pd_lower for the deleted page.
> Also, there was an idea to add a column for LP_DEAD.
> As long as we are dealing with deleted data anyway, maybe let's add this column?
> PFW both patches.

I pushed both of your patches this evening.

Thanks!
--
Peter Geoghegan

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Fujii Masao 2021-02-15 06:15:58 pgsql: Display the time when the process started waiting for the lock,
Previous Message Peter Geoghegan 2021-02-15 04:12:07 pgsql: Add "LP_DEAD item?" column to GiST pageinspect functions