| From: | Peter Geoghegan <pg(at)bowt(dot)ie> |
|---|---|
| To: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
| Cc: | Teodor Sigaev <teodor(at)sigaev(dot)ru>, pgsql-committers <pgsql-committers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: pgsql: Skip full index scan during cleanup of B-tree indexes when possi |
| Date: | 2018-04-18 18:21:02 |
| Message-ID: | CAH2-WzkO5NA-UoFRfL3vf-1fP=_zFY1wDdDq1tNx4o89uoATQw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
On Wed, Apr 18, 2018 at 11:12 AM, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
> On Thu, Apr 5, 2018 at 1:29 AM, Teodor Sigaev <teodor(at)sigaev(dot)ru> wrote:
>> Skip full index scan during cleanup of B-tree indexes when possible
>
> This commit added XLOG_BTREE_META_CLEANUP, so btree_desc() and
> btree_identify() should be updated so that they handle XLOG_BTREE_META_CLEANUP.
> But ISTM that you forgot doing that.
Another thing that I noticed is that the metapage stores
btm_last_cleanup_num_heap_tuples as a float4, even though
xl_btree_metadata stores it as a double. I suggest that both places
store it as float8, to be consistent. (It should not be double because
we always avoid using anything other types with explicit typedef'd
widths in WAL records.)
--
Peter Geoghegan
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alexander Korotkov | 2018-04-18 22:03:06 | Re: pgsql: Skip full index scan during cleanup of B-tree indexes when possi |
| Previous Message | Fujii Masao | 2018-04-18 18:12:28 | Re: pgsql: Skip full index scan during cleanup of B-tree indexes when possi |