| From: | Peter Geoghegan <pg(at)bowt(dot)ie> |
|---|---|
| To: | "Jonathan S(dot) Katz" <jkatz(at)postgresql(dot)org> |
| Cc: | James Coleman <jtc331(at)gmail(dot)com>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, Rafia Sabih <rafia(dot)pghackers(at)gmail(dot)com>, Simon Riggs <simon(at)2ndquadrant(dot)com>, Shaun Thomas <shaun(dot)thomas(at)2ndquadrant(dot)com>, Dmitry Dolgov <9erthalion6(at)gmail(dot)com>, Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Andreas Karlsson <andreas(at)proxel(dot)se> |
| Subject: | Re: [PATCH] Incremental sort (was: PoC: Partial sort) |
| Date: | 2020-07-14 05:59:54 |
| Message-ID: | CAH2-Wz=V-LvfBW50D5u3SROOnnpN45LXiaBqiTh5yDoV=GM=kQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Jul 9, 2020 at 12:06 PM Jonathan S. Katz <jkatz(at)postgresql(dot)org> wrote:
> On 7/2/20 11:47 AM, James Coleman wrote:
> > It seems like the consensus over at another discussion on this topic
> > [1] is that we ought to go ahead and print the zeros [for machine
> > readable output formats], even though that creates some interesting
> > scenarios like the fact that disk sorts will print 0 for memory even
> > though that's not true.
> >
> > The change has already been made and pushed for hash disk spilling, so
> > I think we ought to use Justin's patch here.
>
> Do people agree with James analysis? From the RMT perspective, we would
> like to get this open item wrapped up for the next beta, given[1] is now
> resolved.
Tomas, Justin: Ping? Can we get an update on this?
Just for the record, David Rowley fixed the similar hashagg issue in
commit 40efbf8706cdd96e06bc4d1754272e46d9857875. I don't see any
reason for the delay here.
Thanks
--
Peter Geoghegan
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrey M. Borodin | 2020-07-14 06:25:17 | Re: recovering from "found xmin ... from before relfrozenxid ..." |
| Previous Message | Amit Langote | 2020-07-14 05:49:30 | Re: [PATCH] Performance Improvement For Copy From Binary Files |