| From: | Peter Geoghegan <pg(at)bowt(dot)ie> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | pgsql-committers <pgsql-committers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: pgsql: Add deduplication to nbtree. |
| Date: | 2020-03-01 21:37:16 |
| Message-ID: | CAH2-Wz=Tz_e8e39qTs3Mt78P6XD9s3u7TdOUVrYZg2eTEgfB0w@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
On Sun, Mar 1, 2020 at 11:42 AM Peter Geoghegan <pg(at)bowt(dot)ie> wrote:
> > Do you want to try coding it that way and see what it
> > comes out like?
>
> Sure.
Attached patch shows how this could work. I prefer my original
approach, but I can see the argument for doing it this way.
If we keep my original approach, we should still add a new
"ItemPointerIsValid(&itup->t_tid)" assertion that covers the plain
tupe case in a way that mirrors the current "_bt_posting_valid(itup)"
assert.
--
Peter Geoghegan
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Restructure-_bt_update_posting.patch | application/octet-stream | 2.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2020-03-01 22:14:03 | Re: pgsql: Add deduplication to nbtree. |
| Previous Message | Peter Geoghegan | 2020-03-01 20:12:18 | pgsql: Remove dead code from _bt_update_posting(). |