From: | Peter Geoghegan <pg(at)bowt(dot)ie> |
---|---|
To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
Cc: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: Removing more vacuumlazy.c special cases, relfrozenxid optimizations |
Date: | 2022-03-30 03:08:32 |
Message-ID: | CAH2-Wz=Q2NQprVdf8wojerm-WYwy_eKmLB64mwJ25Prjf=TdvQ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Tue, Mar 29, 2022 at 11:58 AM Peter Geoghegan <pg(at)bowt(dot)ie> wrote:
> > I think I understand what the first paragraph of the header comment
> > for heap_tuple_needs_freeze() is trying to say, but the second one is
> > quite confusing. I think this is again because it veers into talking
> > about what the caller should do rather than explaining what the
> > function itself does.
>
> I wouldn't have done it that way if the function wasn't called
> heap_tuple_needs_freeze().
>
> I would be okay with removing this paragraph if the function was
> renamed to reflect the fact it now tells the caller something about
> the tuple having an old XID/MXID relative to the caller's own XID/MXID
> cutoffs. Maybe the function name should be heap_tuple_would_freeze(),
> making it clear that the function merely tells caller what
> heap_prepare_freeze_tuple() *would* do, without presuming to tell the
> vacuumlazy.c caller what it *should* do about any of the information
> it is provided.
Attached is v13, which does it that way. This does seem like a real
increase in clarity, albeit one that comes at the cost of renaming
heap_tuple_needs_freeze().
v13 also addresses all of the other items from Robert's most recent
round of feedback.
I would like to commit something close to v13 on Friday or Saturday.
Thanks
--
Peter Geoghegan
Attachment | Content-Type | Size |
---|---|---|
v13-0003-vacuumlazy.c-Move-resource-allocation-to-heap_va.patch | application/octet-stream | 5.0 KB |
v13-0002-Generalize-how-VACUUM-skips-all-frozen-pages.patch | application/octet-stream | 19.1 KB |
v13-0001-Set-relfrozenxid-to-oldest-extant-XID-seen-by-VA.patch | application/octet-stream | 60.5 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Julien Rouhaud | 2022-03-30 03:23:45 | Re: Jumble Query with COERCE_SQL_SYNTAX |
Previous Message | Kyotaro Horiguchi | 2022-03-30 02:46:13 | Re: TRAP: FailedAssertion("HaveRegisteredOrActiveSnapshot()", File: "toast_internals.c", Line: 670, PID: 19403) |