Re: Adding skip scan (including MDAM style range skip scan) to nbtree

From: Peter Geoghegan <pg(at)bowt(dot)ie>
To: Tomas Vondra <tomas(at)vondra(dot)me>
Cc: Masahiro(dot)Ikeda(at)nttdata(dot)com, pgsql-hackers(at)lists(dot)postgresql(dot)org, Masao(dot)Fujii(at)nttdata(dot)com
Subject: Re: Adding skip scan (including MDAM style range skip scan) to nbtree
Date: 2024-09-21 17:44:53
Message-ID: CAH2-Wz=L=zHTxJLAowj37r0GWcagEGoqV2DZ_q=BirA-oq7iiQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Sep 18, 2024 at 7:36 AM Tomas Vondra <tomas(at)vondra(dot)me> wrote:
> >> 3) v6-0003-Refactor-handling-of-nbtree-array-redundancies.patch
> >>
> >> - nothing
> >
> > Great. I think that I should be able to commit this one soon, since
> > it's independently useful work.
> >
>
> +1

I pushed this just now. There was one small change: I decided that it
made more sense to repalloc() in the case where skip scan must enlarge
the so.keyData[] space, rather than doing the so.keyData[] allocation
lazily in all cases. I was concerned that my original approach might
regress nested loop joins with very fast inner index scans.

Attached is v8. I still haven't worked through any of your feedback,
Tomas. Again, this revision is just to keep CFBot happy by fixing the
bit rot on the master branch created by my recent commits.

--
Peter Geoghegan

Attachment Content-Type Size
v8-0001-Show-index-search-count-in-EXPLAIN-ANALYZE.patch application/octet-stream 45.1 KB
v8-0003-Add-skip-scan-to-nbtree.patch application/octet-stream 154.7 KB
v8-0002-Normalize-nbtree-truncated-high-key-array-behavio.patch application/octet-stream 12.9 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2024-09-21 18:22:49 Re: Docs pg_restore: Shouldn't there be a note about -n ?
Previous Message Florents Tselai 2024-09-21 17:40:27 Re: Docs pg_restore: Shouldn't there be a note about -n ?