| From: | Peter Geoghegan <pg(at)bowt(dot)ie> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Unimpressed with pg_attribute_always_inline |
| Date: | 2018-01-09 00:20:26 |
| Message-ID: | CAH2-Wz=CgOTppSNyJnAHNYV5XiuhVs-21eTC0WuaKYCoaPWqLQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Jan 8, 2018 at 4:12 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> When I complained that always_inline inhibits debuggability, I did NOT
> mean what shows up in perf reports. I'm talking about whether you can
> break at, or single-step through, a function reliably and whether gdb
> knows where all the variables are. In my experience, inlining hurts
> both of those things, which is why I'm saying that forcing inlining
> even in non-optimized builds is a bad idea.
Isn't that an argument against inlining in general, rather than
forcing inlining in particular?
--
Peter Geoghegan
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2018-01-09 00:22:57 | Re: Unimpressed with pg_attribute_always_inline |
| Previous Message | Andres Freund | 2018-01-09 00:19:35 | Re: Unimpressed with pg_attribute_always_inline |