| From: | Peter Geoghegan <pg(at)bowt(dot)ie> |
|---|---|
| To: | Pavan Deolasee <pavan(dot)deolasee(at)gmail(dot)com> |
| Cc: | Simon Riggs <simon(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com>, Pavan Deolasee <pavan(dot)deolasee(at)2ndquadrant(dot)com>, Stephen Frost <sfrost(at)snowman(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [HACKERS] MERGE SQL Statement for PG11 |
| Date: | 2018-03-24 06:35:01 |
| Message-ID: | CAH2-Wz=A8s1623oQ_B35SWzZsxucEeUTmx0bP412_rv4fm1BKw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Mar 23, 2018 at 11:15 PM, Peter Geoghegan <pg(at)bowt(dot)ie> wrote:
> I agree that this is very similar, as far as the RTEs go. What is
> dissimilar is the fact that there is hard-coded knowledge of both
> through parsing, planning, and execution. It's everything, taken
> together.
>
> ResultRelInfo has a ri_mergeTargetRTI field, which seems to be used
> instead of ri_RangeTableIndex in some contexts but not others. What
> might the interactions with something like GetInsertedColumns() and
> GetUpdatedColumns() be? Is that explained anywhere? In general, I
> think that there is potential for things to break in subtle ways.
I just realized that there were no tests added to privileges.sql. You
only have a small number of GRANT tests in merge.sql, for
relation-level privileges, not column-level privileges. IOW, this area
is totally untested.
--
Peter Geoghegan
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Pavan Deolasee | 2018-03-24 06:52:20 | Re: [HACKERS] MERGE SQL Statement for PG11 |
| Previous Message | Peter Geoghegan | 2018-03-24 06:15:01 | Re: [HACKERS] MERGE SQL Statement for PG11 |